Split main package into multiple subpackages #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atc0005
force-pushed
the
i87-split-main-package-into-subpackages
branch
from
c20fa70
to
7c99851
Compare
This is inspired by #76, but also because I've known for a while that this might eventually be needed. I'm hoping to better isolate code from the main package in the hope/belief that this will make setting up future tests easier and more reliable. As part of this work, the majority of the existing utility functions had to be renamed to export them for use elsewhere and a few functions had to be updated to accept a Config object in order to receive application-wide settings. This Config object also (now) bundles a `*logrus.Logger` for shared use across the application. I don't know Golang well enough at this point to know whether this is a terrible idea. If you're reading this and *you* know the answer, please reach out and share. refs #87, #76
atc0005
force-pushed
the
i87-split-main-package-into-subpackages
branch
from
7c99851
to
f0445cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by #76, but also because I've known for a while that this might eventually be needed. I'm hoping to better isolate code from the main package in the hope/belief that this will make setting up future tests easier and more reliable.
As part of this work, the majority of the existing utility functions had to be renamed to export them for use elsewhere and a few functions had to be updated to accept a Config
object in order to receive application-wide settings. This Config object also (now) bundles a
*logrus.Loggerfor shared use across the application.I don't know Golang well enough at this point to know whether this is a terrible idea. If you're reading this and you know the answer, please reach out and share.
fixes #87