New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go 1.18 Beta 1 released #464
Comments
- switch `unsable` image from `golang:1.17.5` to `golang:1.18beta1 - update README to indicate that the `unstable` image uses the latest `beta` image if available instead of only the latest `rc` or stable release refs GH-464
- switch `unsable` image from `golang:1.17.5` to `golang:1.18beta1` - update README to indicate that the `unstable` image uses the latest `beta` image if available instead of only the latest `rc` or stable release refs GH-464
Getting this output when attempting to build the
|
Replicated with: $ docker container run --rm -it golang:1.18beta1
root@d757671e93fb:/go# apt-get update \
&& apt-get install -y --no-install-recommends \
bsdmainutils=12.1.7+nmu3 \
tree=1.8.0-1+b1 \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/* \
\
&& go install honnef.co/go/tools/cmd/staticcheck@v0.2.2 \
&& staticcheck --version \
&& curl -sSfLO https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh \
&& sh install.sh -b "$(go env GOPATH)/bin" v1.43.0 \
&& golangci-lint --version
Get:1 http://security.debian.org/debian-security bullseye-security InRelease [44.1 kB]
Get:2 http://deb.debian.org/debian bullseye InRelease [116 kB]
Get:3 http://deb.debian.org/debian bullseye-updates InRelease [39.4 kB]
Get:4 http://security.debian.org/debian-security bullseye-security/main amd64 Packages [99.5 kB]
Get:5 http://deb.debian.org/debian bullseye/main amd64 Packages [8180 kB]
Get:6 http://deb.debian.org/debian bullseye-updates/main amd64 Packages [2592 B]
Fetched 8481 kB in 3s (3017 kB/s)
Reading package lists... Done
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following additional packages will be installed:
bsdextrautils ncal
Suggested packages:
calendar whois vacation mailutils
The following NEW packages will be installed:
bsdextrautils bsdmainutils ncal tree
0 upgraded, 4 newly installed, 0 to remove and 0 not upgraded.
Need to get 241 kB of archives.
After this operation, 608 kB of additional disk space will be used.
Get:1 http://deb.debian.org/debian bullseye/main amd64 bsdextrautils amd64 2.36.1-8 [145 kB]
Get:2 http://deb.debian.org/debian bullseye/main amd64 ncal amd64 12.1.7+nmu3 [30.1 kB]
Get:3 http://deb.debian.org/debian bullseye/main amd64 bsdmainutils all 12.1.7+nmu3 [16.4 kB]
Get:4 http://deb.debian.org/debian bullseye/main amd64 tree amd64 1.8.0-1+b1 [49.6 kB]
Fetched 241 kB in 1s (404 kB/s)
debconf: delaying package configuration, since apt-utils is not installed
Selecting previously unselected package bsdextrautils.
(Reading database ... 15713 files and directories currently installed.)
Preparing to unpack .../bsdextrautils_2.36.1-8_amd64.deb ...
Unpacking bsdextrautils (2.36.1-8) ...
Selecting previously unselected package ncal.
Preparing to unpack .../ncal_12.1.7+nmu3_amd64.deb ...
Unpacking ncal (12.1.7+nmu3) ...
Selecting previously unselected package bsdmainutils.
Preparing to unpack .../bsdmainutils_12.1.7+nmu3_all.deb ...
Unpacking bsdmainutils (12.1.7+nmu3) ...
Selecting previously unselected package tree.
Preparing to unpack .../tree_1.8.0-1+b1_amd64.deb ...
Unpacking tree (1.8.0-1+b1) ...
Setting up bsdextrautils (2.36.1-8) ...
update-alternatives: using /usr/bin/write.ul to provide /usr/bin/write (write) in auto mode
Setting up ncal (12.1.7+nmu3) ...
Setting up bsdmainutils (12.1.7+nmu3) ...
Setting up tree (1.8.0-1+b1) ...
go: downloading honnef.co/go/tools v0.2.2
go: downloading golang.org/x/tools v0.1.0
go: downloading github.com/BurntSushi/toml v0.3.1
go: downloading golang.org/x/sys v0.0.0-20210119212857-b64e53b001e4
go: downloading golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1
go: downloading golang.org/x/mod v0.3.0
staticcheck 2021.1.2 (v0.2.2)
golangci/golangci-lint info checking GitHub for tag 'v1.43.0'
golangci/golangci-lint info found version: 1.43.0 for v1.43.0/linux/amd64
golangci/golangci-lint info installed /go/bin/golangci-lint
panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt
goroutine 1 [running]:
github.com/go-critic/go-critic/checkers.init.9()
github.com/go-critic/go-critic@v0.6.1/checkers/checkers.go:58 +0x4b4
root@d757671e93fb:/go#
|
root@d757671e93fb:/go# nano test.go
root@d757671e93fb:/go# cat test.go
package main
import "fmt"
func main() {
fmt.Println("Hello World")
}
root@d757671e93fb:/go# go run test.go
Hello World
root@d757671e93fb:/go# go build test.go
root@d757671e93fb:/go# ./test
Hello World The |
Waiting on golangci/golangci-lint#2374 before going further. |
It doesn't sound like there is interest in supporting the beta from the golangci-lint team. |
Further conversation on go-critic/go-critic#1157. While there isn't interest in directly supporting the Go 1.18beta1 from the golangci-lint team (which is understandable, supporting beta releases adds a support burden), the problem may be fixed upstream and indirectly resolved with a future golangci-lint release. This issue remains blocked until that occurs. |
Alternatively, I can try building from source instead of using the official install script. Per https://golangci-lint.run/usage/install/#install-from-source:
Might take a little longer to generate images, but should (hopefully) give more stable results? That, or perhaps fail faster if there is an incompatibility with the base image used. Might be worth using this approach specifically for the |
Mixed results when building from source and running golangci-lint v1.43.0 against an existing project I maintain.
I'm not particularly optimistic about the stability of the |
- build golangci-lint from source - split image creation into builder/final stages, copy Go binaries from builder stage into final Brief testing has shown questionable results, but pushing this out anyway to gather live feedback from live CI tests/builds. refs GH-464
Looks like work has begun in earnest on Go 1.18 compatibility support: As noted in the PR description, multiple linters currently panic. It looks like the Go 1.18 beta/rc process will be a bit more bumpy than earlier Go versions (not unexpected). |
- switch `unsable` image from `golang:1.17.5` to `golang:1.18beta1` - update README to indicate that the `unstable` image uses the latest `beta` image if available instead of only the latest `rc` or stable release refs GH-464
- build golangci-lint from source - split image creation into builder/final stages, copy Go binaries from builder stage into final Brief testing has shown questionable results, but pushing this out anyway to gather live feedback from live CI tests/builds. refs GH-464
Per https://groups.google.com/g/golang-announce/c/eAjK4Oezs_A:
I expect that the new upstream Docker image will be ready sometime later today or tomorrow.
The text was updated successfully, but these errors were encountered: