Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh list of disabled linters (due to Go 1.18+ incompatibilities) for golangci-lint v1.47.1 release #681

Closed
3 tasks done
atc0005 opened this issue Jul 20, 2022 · 0 comments · Fixed by #683
Closed
3 tasks done

Refresh list of disabled linters (due to Go 1.18+ incompatibilities) for golangci-lint v1.47.1 release #681

atc0005 opened this issue Jul 20, 2022 · 0 comments · Fixed by #683
Assignees
@atc0005
Labels
stable unstable
Milestone
v0.6.19

Comments

@atc0005
Copy link
Owner

atc0005 commented Jul 20, 2022 •
edited

Overview

The golangci-lint v1.47.0 release was expected to resolve most Go 1.18+ incompatibilities (bundled linters), but an issue with the test suite incorrectly flagged problematic linters as compatible. The v1.47.1 release disables known incompatible linters incorrectly flagged as compatible in the v1.47.0 release.

TODO

I should perform the following actions:

  • review the compatibility table on Support of generics golangci/golangci-lint#2649
  • restore the disabled list to the stable and unstable copies of the golangci-lint config files
  • populate the disabled list with any linters confirmed to have issues with Go 1.18+

References
@atc0005 atc0005 added this to the Next Release milestone Jul 20, 2022
@atc0005 atc0005 self-assigned this Jul 20, 2022
atc0005 added a commit that referenced this issue Jul 20, 2022
@atc0005
Refresh disabled linters for golangci-lint v1.47.1
11f1915 
- restore `disable` block in unstable config file
  - add `rowserrcheck`
  - add `sqlclosecheck`
  - add `structcheck`
  - add `wastedassign`
- restore `disable` block in stable config file
  - add `rowserrcheck`
  - add `sqlclosecheck`
  - add `structcheck`
  - add `wastedassign`

refs GH-681
@atc0005 atc0005 mentioned this issue Jul 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
stable unstable
Projects
None yet
Milestone
v0.6.19
Development

Successfully merging a pull request may close this issue.

Refresh disabled linters for golangci-lint v1.47.1 atc0005/go-ci
1 participant
@atc0005