Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Adaptive Card Table support #220

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Mar 28, 2023

Overview

Add early implementation of Adaptive Card Table support.

Changes

  • Expand base/shared Element type with fields specific to the Table type
  • Refresh documentation for Column type to note that it serves a dual role
    • member of a ColumnSet
    • member of a Table (TableColumnDefinition)
  • Add new types specific to tables
  • Examples
    • add example of manually creating a table
    • add example of creating a table with headers
    • add example of creating a table of unordered "grid" values
  • README
    • Add references to new examples
    • Add Table element documentation reference

Limitations

Support for Adaptive Card Table elements is new. There are likely sharp edges and missing support. Feedback is welcome.

References

@atc0005 atc0005 added documentation Improvements or additions to documentation enhancement New feature or request card format/adaptivecard Adaptive Card support labels Mar 28, 2023
@atc0005 atc0005 added this to the v2.8.0 milestone Mar 28, 2023
@atc0005 atc0005 self-assigned this Mar 28, 2023
@atc0005
Copy link
Owner Author

atc0005 commented Jun 9, 2023

No feedback received thus far.

I'll plan to rebase this branch and merge in the near future then cut a RC release.

OVERVIEW

Add early implementation of Adaptive Card Table support.

CHANGES

- Expand base/shared Element type with fields specific to the
  Table type
- Refresh documentation for Column type to note that it serves a
  dual role
  - member of a ColumnSet
  - member of a Table (TableColumnDefinition)
- Add new types specific to tables
- Examples
  - add example of manually creating a table
  - add example of creating a table with headers
  - add example of creating a table of unordered "grid" values
- README
  - Add references to new examples
  - Add Table element documentation reference

LIMITATIONS

Support for Adaptive Card Table elements is new. There are likely
sharp edges and missing support. Feedback is welcome.

REFERENCES

- refs GH-205
- https://adaptivecards.io/explorer/Table.html
@atc0005 atc0005 force-pushed the i205-add-adaptivecard-table-support branch from d8774f7 to 800fc1f Compare June 9, 2023 10:47
@atc0005 atc0005 marked this pull request as ready for review June 9, 2023 10:49
@atc0005 atc0005 merged commit 8579ae0 into master Jun 9, 2023
22 of 23 checks passed
@atc0005 atc0005 deleted the i205-add-adaptivecard-table-support branch June 9, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
card format/adaptivecard Adaptive Card support documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant