Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move golangci-lint options to dedicated config file #4

Closed
atc0005 opened this issue Apr 10, 2020 · 1 comment
Closed

Move golangci-lint options to dedicated config file #4

atc0005 opened this issue Apr 10, 2020 · 1 comment
Assignees
@atc0005
Labels
builds ci enhancement New feature or request golang linting
Milestone
Future

Comments

@atc0005
Copy link
Owner

atc0005 commented Apr 10, 2020

See also atc0005/send2teams#42. Pretty sure that I've got a similar issue open in atc0005/elbow already.
@atc0005 atc0005 added this to the Future milestone Apr 10, 2020
@atc0005 atc0005 self-assigned this Apr 10, 2020
This was referenced Apr 10, 2020
Closed
Closed
atc0005 added a commit to atc0005/send2teams that referenced this issue Apr 11, 2020
@atc0005
Export golangci-lint options, add scopelint linter
5415b5f 
Summary:

- Move linter choices from Makefile to separate include file

- Add scopelint linter to help catch variable use
  outside of intended scope

References:

- #42
- #44
- atc0005/todo#4
- dasrick/go-teams-notify#14
@atc0005 atc0005 mentioned this issue Apr 11, 2020
Merged
This was referenced Apr 23, 2020
Closed
Closed
@atc0005 atc0005 mentioned this issue May 1, 2020
Closed
@atc0005
Copy link
Owner Author

atc0005 commented Aug 6, 2020

Pretty sure that this is complete. Additionally, a default copy of the config file is provided by the atc0005/go-ci Docker containers.

@atc0005 atc0005 closed this as completed Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
builds ci enhancement New feature or request golang linting
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@atc0005