-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute analytically the radiation integrals #122
Conversation
This is now OK for me. New features:
Function names can still be modified if there are better names! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to merge this. I think the tests comparing Matlab and Python results are becoming very useful.
Ok, @willrogers, go on merging. I see that the correction for NumIntSteps is still in a pending pull request, so I add it here. I have also a question on the updates of the Pypi repository: when is it updated? Since pyat is still evolving quite fast, I would push for rather frequent updates… |
In principle, if I push a tag I'm happy to try that now (0.0.2), then when we've merged the Diamond changes I can make a 0.0.3 release. |
The 5 radiation integrals are computed analytically by
get_radiation_integrals
inradiation.py
. 2 new functions allow a comparison between results obtained from the radiation integrals (radiation_parameters
) and from ohmi_envelope (envelope_parameters
).A slight difference with Matlab in i4 is under investigation