Use the safer lattice_pass instead of atpass in tests #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a problem with |
|
Problem solved in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except for
test_atpass.py, which of course still testsatpass, the test sequence use the safer "public" interface for tracking:lattice_passinstead ofatpass(with the same arguments).Tracking lattices with a single element (
atpass([elem],...)is replaced by direct tracking through the element (element_pass(elem,...))lattice_passmakes some coherence checks (Fortran-ordering of data for instance) before callingatpass. In the future,atpassmay be turned into a private function, with a deprecation warning for existing code.For the moment, this PR does not change anything, neither on AT use, nor on the test sequence.