Initialisation of the harmonic number #401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@simoneliuzzo and @swhite2401 pointed out in #391 a problem with the
harmonic_number
Lattice attribute. It is properly initialised when creating a lattice, but not when a lattice is modified: if the attribute does not exist initially (no cavity in the lattice), it is not added if a cavity is added to the lattice. This concerns the following actions:insert
,append
andextend
methods,+
and+=
operators.This is corrected here, as well as updating properly the
radiation
property in the same events.