Update of setuptools_scm #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The python default at ESRF is 3.7, on our side it is ok to drop support for python 3.6 |
|
@swhite2401 : I' m just asking the question, it's not urgent but it'll allow some simplifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The versioning of pyat is handled by
setuptools_scm. Up to now, a bug prevented storing the generated version number in a python file_version.py(just because pyat is not at the root of the git repository). This is now corrected. As a consequence, at run time, we can now import the version number from the_versionmodule, rather than extracting it from the metadata of the package. This makes the import ofatsimpler and faster.There is still a trick to handle python 3.6. Another question is: how long do we still need to support python 3.6?