-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix empty orbit in atlinopt #434
Conversation
This is what is done in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Thanks, I checked and this is what is done in |
@swhite2401 : I think this is not the right place for the fix. |
Well if the rmatrix is missing it will fail... the other option is to provide a function that derives the rmatrix from atlinopt output but do you really want to go in this direction? |
By the way the same problem is in pyAT |
Of course yes: if |
Another good reason to open a dedicated PR ! |
Ok I roll back the last commit and merge this one. |
This reverts commit ad91491.
This PR fixes an issue with
atlinopt
withtwiss_in
activated.When orbit_in was not provided an empty list was returned instead of 6 zeros.
The implementation could be further improved by using twiss_in.ClosedOrbit instead of zeros(6,1), to be discussedIf present the default is
twiss_in.ClosedOrbit