Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix atcavityoff #447

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Fix atcavityoff #447

merged 2 commits into from
Jul 19, 2022

Conversation

lfarv
Copy link
Contributor

@lfarv lfarv commented Jul 19, 2022

atcavityoff did not correctly return the index of cavities (see #446). This is corrected here.

@lfarv
Copy link
Contributor Author

lfarv commented Jul 19, 2022

Note that there is a difference of meaning of cavitiesIndex between atradon/atradoff and atcavityoff.

  • in atradon/atradoff, the cavities index points to active cavities. Since both functions allow the modification of some elements while keeping others intact, this is a valuable information,
  • in atcavityon/atcavityoff (original version), the cavities index points to all cavities, independently of their state. This behaviour is restored here. The problem might even have occurred in atcavityon if the user for some reason, would set cavipass to a non-cavity passmethod.

Copy link
Contributor

@lnadolski lnadolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes the job
Thanks

@lfarv lfarv added Matlab For Matlab/Octave AT code bug fix labels Jul 19, 2022
@lfarv lfarv merged commit 413c4af into master Jul 19, 2022
@lfarv lfarv deleted the fix_atcavityoff branch July 19, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Matlab For Matlab/Octave AT code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants