Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipole can be instantiated #455

Merged
merged 4 commits into from
Aug 12, 2022
Merged

Multipole can be instantiated #455

merged 4 commits into from
Aug 12, 2022

Conversation

lfarv
Copy link
Contributor

@lfarv lfarv commented Aug 4, 2022

Issue #454 reveals a problem when saving/loading Multipole instances in .mat format. This is fixed here

@lfarv lfarv added Python For python AT code bug fix labels Aug 4, 2022
@lfarv lfarv requested a review from swhite2401 August 4, 2022 16:52
Copy link
Contributor

@swhite2401 swhite2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me

@swhite2401 swhite2401 self-requested a review August 8, 2022 07:10
@swhite2401
Copy link
Contributor

@lfarv, sorry I take it back, save and loading still fails for again the same problem: K is defined as an attribute of multipole in the matlab lattice. You have to pop() it before you initialize the element otherwise K is set before PolynomB is defined (and I supposed the same should be implemented for H).

@lfarv
Copy link
Contributor Author

lfarv commented Aug 9, 2022

Hello @swhite2401

save and loading still fails for again the same problem

I cannot reproduce your problem. K is no more saved for multipoles. Are you sure you don't try to load an old wrong file? Or use the wrong branch?

@swhite2401
Copy link
Contributor

Yes sorry, I looked in details and this was one specific case where I voluntarily instantiate a Multipole withK defined in kwargs.
I suppose we can live with this, I do not see why anyone would do this.

So ok for me to merge.

@lfarv lfarv merged commit 869e2f6 into master Aug 12, 2022
@lfarv lfarv deleted the instantiable_multipole branch August 12, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Python For python AT code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants