Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix acceptance #457

Merged
merged 14 commits into from
Aug 16, 2022
Merged

Fix acceptance #457

merged 14 commits into from
Aug 16, 2022

Conversation

swhite2401
Copy link
Contributor

Several bugs/unwanted features found in the acceptance modules are fixed in this PR:

  • GridMode.RECURSIVE was allowed to go in the negative direction for radial search, now it cannot cross zero
  • nturns=1 was crashing the code, this is now allowed
  • Empty survived array was crashing the code, now an AtError is raised
  • Forcing the grid to RECURSIVE in 2D was found to be inconvenient, this is now done only for the 1D case

@swhite2401 swhite2401 added bug fix Python For python AT code labels Aug 10, 2022
@swhite2401 swhite2401 merged commit e76561e into master Aug 16, 2022
@swhite2401 swhite2401 deleted the fix_acceptance branch August 16, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneliuzzo simoneliuzzo simoneliuzzo approved these changes

Assignees
No one assigned
Labels
bug fix Python For python AT code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@swhite2401 @simoneliuzzo