Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit integer tune #458

Merged
merged 5 commits into from
Aug 16, 2022
Merged

Fit integer tune #458

merged 5 commits into from
Aug 16, 2022

Conversation

swhite2401
Copy link
Contributor

This PR adds to possibility to fit the integer part of the tune either by set fit_integer=True as argument or providing a non-zero integer part for one of the target values.
Follow-up from #456

@simoneliuzzo
Copy link
Contributor

Dear @swhite2401 , thank you for this addition. The function get_tune may be should have the same optional input?
for example, to check that the tune correction is correctly done I would do:

initial_tune = get_tune(ring, ..., use_integer = True)
ring_tune = at.matching.fit_tune(ring, ...,fit_integer=True)
final_tune = get_tune(ring_tune, ..., use_integer = True)

@simoneliuzzo
Copy link
Contributor

Dear @swhite2401

the help of at.matching.globalfit.fit_tune gives examples that are may be not up to date.
The help of get_tune could be complemented with the get_integer optional flag

@swhite2401 swhite2401 added enhancement Python For python AT code labels Aug 10, 2022
@simoneliuzzo
Copy link
Contributor

works for me

Copy link
Contributor

@lfarv lfarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Apart from the minor warnings I get (mentioned above), it's ok for me.

@swhite2401 swhite2401 merged commit 9493c00 into master Aug 16, 2022
@swhite2401 swhite2401 deleted the fit_integer_tune branch August 16, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Python For python AT code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants