-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fit integer tune #458
Fit integer tune #458
Conversation
Dear @swhite2401 , thank you for this addition. The function get_tune may be should have the same optional input?
|
Dear @swhite2401 the help of at.matching.globalfit.fit_tune gives examples that are may be not up to date. |
works for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Apart from the minor warnings I get (mentioned above), it's ok for me.
This PR adds to possibility to fit the integer part of the tune either by set
fit_integer=True
as argument or providing a non-zero integer part for one of the target values.Follow-up from #456