Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take "QuantPass" into account when checking 6D motion #507

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Conversation

lfarv
Copy link
Contributor

@lfarv lfarv commented Oct 24, 2022

The passmethods ending in QuantPass are forgotten when checking for 6D motion or disabling it. this PR fixes that. It upgrades:

  • Matlab: check_6d, check_radiation, atenable_6d, atdisable_6d, atradon, atradoff
  • python: check_6d, check_radiation, Lattice.enable_6d, Lattice.disable_6d, Element.get_longt_motion, Element.set_longt_motion

enable_6d is unchanged: by default it enables "classical" radiation by setting '*RadPass', possibly replacing '*QuantPass' if necessary.

Enabling *QuantPass can be explicitly required, but an easier way to do that is still to be discussed.

@lfarv lfarv added Matlab For Matlab/Octave AT code Python For python AT code bug fix labels Oct 24, 2022
@lfarv lfarv requested a review from swhite2401 October 24, 2022 15:00
Copy link
Contributor

@swhite2401 swhite2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@lfarv lfarv merged commit 63bf0a1 into master Oct 27, 2022
@lfarv lfarv deleted the fix_check_6d branch October 27, 2022 12:34
@lfarv lfarv mentioned this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Matlab For Matlab/Octave AT code Python For python AT code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants