-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elemrnt rotations #519
Elemrnt rotations #519
Conversation
@elafmusa, I could not add you as reviewer but could you please check this is doing what you expected? Thanks! |
@swhite2401 : Just for my understanding: why is it necessary to round the rotation values? |
I had rounding errors of ~1e-19 when applying a transformation and then reverting if with It is not necessary, more of a cosmetic measure |
I think this is a nice addition. I do not have time to review, so I removed myself from reviewers. |
@swhite2401 I tested the implemented functions, and it works as expected thanks! |
Ok I merge, you may switch back to the master branch |
This PR is a follow-up of #512. It was pointed out that there was no function to provide pitch and yaw in python. The proposed solution was using the wrong coordinate system and needed to be improved.
The change of coordinate from angle (input argument) to momentum is done using the
R1
andR2
matrices.relative
option is still available but a bit tricky because some of the transformations are not commutative.This implementation is a at the stage of a proposal, ideas and suggestions welcome!
If we are happy with this, it can easily be ported to matlab.