Update quantum diffusion pass methods #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcarver
approved these changes
Dec 2, 2022
|
Waiting for #532 to be merged |
|
Looks ok to be but has this been tested? Is tracking giving the correct equilibrium emittance? |
Yes, this was the only test that I did. I also checked to see how many particles were needed to converge on the same sigma_matrix, I found that you needed at least 10000 particles. But also I didn't do a very thorough testing, just of the diagonal terms. |
swhite2401
approved these changes
Dec 5, 2022
lfarv
force-pushed
the
update_quantum_diffusion
branch
from
f768413
to
f92acb6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuantDiffPass,BndMPoleSymplectic4QuantPassandStrMPoleSymplectic4QuantPassare now using the RNGs introduced in #513.Also
atrandom.cis modified to add mean and stdev input arguments to the Gaussian generator, soVariableThinMPolePasshad also to be updated.The
atrandom.cinterface should now be stable.