Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular imports #570

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Fix circular imports #570

merged 2 commits into from
Mar 2, 2023

Conversation

lfarv
Copy link
Contributor

@lfarv lfarv commented Mar 1, 2023

This corrects some circular import problems which appeared while developing. The modifications are:

  • the Orbit type is declared earlier (in lattice rather than physics), but is still defined in physics for compatibility,
  • some imports in lattice/__init__.py and physics/__init__.py are reordered,
  • some function calls are replaced by calls to Lattice methods to avoid imports.

@lfarv lfarv added the Python For python AT code label Mar 1, 2023
@lfarv lfarv merged commit 3b8b8ec into master Mar 2, 2023
@lfarv lfarv deleted the circular_imports branch March 2, 2023 13:51
@lfarv lfarv mentioned this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python For python AT code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant