Fixes bug producing infrequent NaN from calcnaff #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfarv
approved these changes
Mar 28, 2023
Comment on lines
-74
to
-81
| %It seems there is a bug in nafflib, something returns nan even for valid data | ||
| niter = 0; | ||
| while any(isnan(frequency)) && (niter < nitermax) | ||
| pause(2); | ||
| fprintf('Warning Nan returned by NAFF (x%d)\n', niter); | ||
| niter = niter +1; | ||
| [frequency,amplitude,phase] = nafflib(Y, Yp, WindowType,nfreq,1); % add debugging | ||
| end |
There was a problem hiding this comment.
So apparently, up to now, if the output is wrong, we try again until it gets right !
This looks crazy, your fix is really welcome, @pcsch !
The second test for NaN was wrong Y was replaced by Yp
lnadolski
reviewed
Mar 29, 2023
Comment on lines
-74
to
-81
| %It seems there is a bug in nafflib, something returns nan even for valid data | ||
| niter = 0; | ||
| while any(isnan(frequency)) && (niter < nitermax) | ||
| pause(2); | ||
| fprintf('Warning Nan returned by NAFF (x%d)\n', niter); | ||
| niter = niter +1; | ||
| [frequency,amplitude,phase] = nafflib(Y, Yp, WindowType,nfreq,1); % add debugging | ||
| end |
lfarv
approved these changes
Mar 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear all,
This pull request concerns MATLAB.
As noted in #40 calcnaff sometimes produces NaN values even though the input is valid and a second run does result in valid frequencies.
The problem is that the interface between MATLAB and the NAFF algorithm did no write to the last element of the
complex input to NAFF.
This pull request fixes that.
In my tests this also fixed the fluctuating results from run to run (e.g. phase) seen in #40 as well.
Fixes #40