Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct return type of wakefunc_long_resonator #591

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Correct return type of wakefunc_long_resonator #591

merged 1 commit into from
Apr 3, 2023

Conversation

lfarv
Copy link
Contributor

@lfarv lfarv commented Apr 3, 2023

The wakefunc_long_resonator() C function does not return anything. Its return type should be void instead of double *.

@lfarv lfarv added Matlab For Matlab/Octave AT code Python For python AT code bug fix labels Apr 3, 2023
@lfarv lfarv requested review from swhite2401 and lcarver April 3, 2023 11:23
@lfarv lfarv merged commit 40be867 into master Apr 3, 2023
31 checks passed
@lfarv lfarv deleted the wakefunc_return_type branch April 3, 2023 13:09
@lfarv lfarv mentioned this pull request Jun 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swhite2401 swhite2401 swhite2401 approved these changes

@lcarver lcarver lcarver approved these changes

Assignees
No one assigned
Labels
bug fix Matlab For Matlab/Octave AT code Python For python AT code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lfarv @swhite2401 @lcarver