Documentation for Collective Effects #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can check the result here. Good for me, except that there is no syntax highlighting in code blocks. Maybe use |
lfarv
reviewed
May 17, 2023
|
This is very nice ! A detail: could you put cross-reference links for the end notes, and also possibly links to the reference papers ? Apparently they are freely available:
|
|
This look fine for me too, adding links as @lfarv mentioned would be nice indeed |
added 2 commits
May 24, 2023 11:52
|
All comments so far have been implemented. Simone only read half of the document so I wait a bit longer. |
lfarv
reviewed
May 24, 2023
simoneliuzzo
approved these changes
May 25, 2023
|
ready for merge, needs final approval |
swhite2401
approved these changes
May 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unable to check the formula as it doesn't display in the github page viewer. Nonetheless it can still be reviewed, and I encourage reviewers to propose or make modifications as they see fit.