Fix the creation of .mat files #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarxblanco
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
I have made a simplified test using a lattice with a single sextupole and it executes w/o errors.
(NOTE : here I use a custom script called setatversion that sets the AT matlab version under test)
python -c "import at; s1 = at.Sextupole('S6',0.4,-3.6); ring = at.Lattice([s1],energy='1'); at.save_mat(ring,'pyatsaveSext.mat');"
matlab -nosplash -nodisplay -r "clear all; setatversion;load('pyatsaveSext.mat'); atwritem(RING,'matlabwriteSext.m');exit;"
python -c "import at; ring=at.load_m('matlabwriteSext.m')"Additionally, I did a test with a more general lattice and it also executes w/o issues.
I think this could be safely merged.
lnadolski
added a commit
that referenced
this pull request
Oct 25, 2023
…into include_soleil_changes * 'EnergyLossRadPass' of https://github.com/atcollab/at.git: fixed ringpara and atsummary Update atenable_6d.m Update atdisable_6d.m Update atenergyloss.m Remove the Energy field in python Computation of energy loss with 'integral' method working Handled enable/disable_6d, element constructors in python and Matlab, load and save .m and .mat files Update EnergyLossRadPass.c Added EnergyLossRadPass Added EnergyLossRadPass Fix the creation of .mat files (#627)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug reported by @oscarxblanco here.
The following sequence:
throws an Exception when reading sextuples.
Explanation: The attribute
H(sextuple strength) exists as a property in python, but does not exist in Matlab. It is not present in .mat files created in Matlab, but does exist in .mat files created in python. When reading such a file in Matlab, the sextupoles get an unexpectedHattribute, which has no detrimental effect, However when saving in a .m file,His printed as a "exotic" attribute, which is wrongly interpreted.In this PR,
Hdoes not appear in .mat files created in python.