Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rails 5 alias_method_chain deprecation #8

Closed
wants to merge 1 commit into from

Conversation

wagenet
Copy link

@wagenet wagenet commented Jul 28, 2016

No description provided.

@wagenet
Copy link
Author

wagenet commented Jul 28, 2016

Test failures are unrelated to my change.

@atd
Copy link
Owner

atd commented Jul 29, 2016

Thank you for the pull request @wagenet

Sorry but I have been disconnected from Rails for 3 years and I am not aware on how engine's path are managed in Rails 5

Tests should also be fixed. I have done some work on the travis branch, but an update of the dummy app is needed.

I hope I get some time for it in a couple of weeks. Sorry for that. Of course, a pull request that updates the tests is very welcomed

@gwalshington
Copy link

gwalshington commented Nov 20, 2017

I'm currently running into this issue as well. Any update on this issue?

@wagenet
Copy link
Author

wagenet commented Nov 29, 2017

@gwalshington my branch should work for now.

@wagenet
Copy link
Author

wagenet commented Nov 29, 2017

@atd to be clear, this doesn't change how paths are managed, it just changes how the method overwrite happens to not use alias_method_chain.

@wagenet
Copy link
Author

wagenet commented Jun 28, 2022

I've closed this pull request, but for the time being I will continue to leave the branch if anyone is using it. However, I would recommend not relying upon it in case it gets deleted in the future.

@wagenet wagenet closed this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants