Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DnDTabbedPane. Idx for insertion selection fix. #24

Merged
merged 1 commit into from Feb 23, 2024

Conversation

AndreiKud
Copy link
Contributor

Hello. Thanks for maintaining this repo! I brought two minor improvements for DnDTabbedPane component.

  1. Stopping traversing components after forward/backward buttons are already found.
  2. Fixed incorrect tab insertion idx selection, when a small tab comes before a big tab (more than twice higher/wider)
    Bug:
    bug
    Fix:
    fix

Previously we checked tab rect by translating it backward by its half. I suggest checking halfs of the rect within original bounds. Explicit check for last tab remains the same, but extended to full width instead of half.

@AndreiKud
Copy link
Contributor Author

@aterai you will check it when you have time, right?

@aterai
Copy link
Owner

aterai commented Feb 23, 2024

you will check it when you have time, right?

Yes, I will check it from now on as I may have time this weekend.

Copy link
Owner

@aterai aterai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the bug in my environment and confirm that the fix works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants