API 4.0.0 #10
Merged
API 4.0.0 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianVennen
requested changes
Jun 15, 2023
|
Will switch back to pulling from maven when I'm home in a few hours |
JulianVennen
requested changes
Jun 15, 2023
|
I'll merge this tomorrow, I can also do these changes myself then. Once again, thanks for your contributions. |
|
all done, and pulled some other things you did today from other repos 👍 didn't realize I missed so much, apologies |
JulianVennen
requested changes
Jun 16, 2023
.github/workflows/build.yml
Outdated
Comment on lines
16
to
17
| - name: init submodule | ||
| run: git submodule init && git submodule update |
There was a problem hiding this comment.
this is no longer required
settings.gradle
Outdated
Comment on lines
2
to
3
| project(':mclogs-java').projectDir = new File('./mclogs-java/') |
There was a problem hiding this comment.
this is also not required anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Releasing will have to be altered with the shadow update, likely just to fix naming conventions. This will also require updating the release workflow