Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle does not draw at all in IE 8 #150

Open
DavidAcreman opened this issue Dec 31, 2013 · 8 comments
Open

Circle does not draw at all in IE 8 #150

DavidAcreman opened this issue Dec 31, 2013 · 8 comments

Comments

@DavidAcreman
Copy link

Please see the screenshot below of IE 8 problem (this is using excanvas3 to get it to work at all)

http://screencast.com/t/tA3ujO4BEu9W

It should work as shown in this screenshot from Chrome of the same code:

http://screencast.com/t/SxhBec3mWNr

I am using the jquery.knob.js file from the HEAD of this repo, and there is little to no documentation / information on why this should be happening in IE8.

I have followed the steps in this stackoverflow (with the exception of editing the knob.js file as they suggest, as the HEAD version of the file incorporates this code already)

http://stackoverflow.com/questions/14743161/jquery-knob-not-working-in-ie-8/15291947#15291947

@zitrusblau
Copy link

try my temporal fix:
https://github.com/zitrusblau/jQuery-Knob

@DavidAcreman
Copy link
Author

Fix works to get the dial drawing - thanks! Now it seems that when it is set to 0 it doesn't draw quite the whole way round. Also the angle offset appears to work strangely - see the screenshot below and the difference between it set to 9 and 88.

Thank you again for the fix, it will keep my project on track (as my javascript is rubbish sadly!) :)

http://screencast.com/t/0uGa6voK

@aterrien
Copy link
Owner

aterrien commented Jan 9, 2014

@zitrusblau: I've merged your great patch for IE8, I don't have any IE8 vm at home :(, can you validate the head (1.2.4) ?

@zitrusblau
Copy link

Hey,

the gap on max-value was there all the time, wasn't it.

are you having the other issue only on IE 8 or with all browsers. could you specify more precisly, how your knobs are set up?

Daniel Klotz

ZITRUSBLAU GmbH
Keithstraße 41 · 10787 Berlin
www.zitrusblau.de
Fon 030.257 587- 84
Zentrale 030.214 777- 00
Fax 030.214 777- 01

Am 09.01.2014 um 10:59 schrieb DavidAcreman:

Fix works to get the dial drawing - thanks! Now it seems that when it is set to 0 it doesn't draw quite the whole way round. Also the angle offset appears to work strangely - see the screenshot below and the difference between it set to 9 and 88.

Thank you again for the fix, it will keep my project on track (as my javascript is rubbish sadly!) :)

http://screencast.com/t/0uGa6voK


Reply to this email directly or view it on GitHub.

@zitrusblau
Copy link

hey,

just check in IE Tester for IE 8 VM and it works quite nicely.
don't have a native IE 8 here to test, though.

Daniel Klotz

ZITRUSBLAU GmbH
Keithstraße 41 · 10787 Berlin
www.zitrusblau.de
Fon 030.257 587- 84
Zentrale 030.214 777- 00
Fax 030.214 777- 01

Am 09.01.2014 um 22:55 schrieb Anthony Terrien:

@zitrusblau: I've merged your great patch for IE8, I don't have any IE8 vm at home :(, can you validate the head (1.2.4) ?


Reply to this email directly or view it on GitHub.

@DavidAcreman
Copy link
Author

I don't see the gap on Firefox or Chrome when viewing the same web page with the same data on it.

The markup I am using is below (also have linked it as Github doesn't like me adding script / markup directly into my comment)
http://screencast.com/t/33y9ND0qdFu

<script type="text/javascript"> $(function () { $(".js-knob").knob({ 'draw': function () { if ($(this.i).val().indexOf('%') == -1) { $(this.i).val(this.cv + '%'); } } }); $(".js-knob").css('font-size', '20px'); }); </script>

@DavidAcreman
Copy link
Author

IE8: http://screencast.com/t/GhKGV8QR
FF 26.0: http://screencast.com/t/xoIpjRD9M
Chrome 31.0.1650.59 m: http://screencast.com/t/rQ3bOhwT

As you can see IE always has a tiny gap at minimum or max value!

@TheBokiya
Copy link

I have this problem which IE doesn't draw the circle if the readonly value is equal to the max value. Very weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants