Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mapshaper #130

Merged
merged 33 commits into from
Apr 7, 2023
Merged

Update mapshaper #130

merged 33 commits into from
Apr 7, 2023

Conversation

ateucher
Copy link
Owner

@ateucher ateucher commented Apr 6, 2023 •
edited

  • Update bundled mapshaper library to 0.6.25
  • Update testthat to e3
  • Remove geogsonio
  • Copy as.SpatialLinesDataFrame.SpatialLines and as.SpatialPointsDataFrame.SpatialPoints methods from geojsonio.

I had to do some gymnastics with quoting some of the mapshaper call - specifically adding -each 'rmapshaperid=this.id' via force_FC. Just using single quotes works everywhere with the bundled mapshaper, but fails on Windows when using sys_mapshaper(), which uses system2(). But using shQuote() on Windows quotes the string in a way that is incompatible with V8. So now it uses '' when sys=FALSE and shQuote() when `sys=TRUE.

@ateucher
Copy as.Spatial* methods from geojsonio
ea08cff
@ateucher
Update instructions for updating mapshaper version
5a24a39
@ateucher
Hard-code bundled mapshaper version
9f5eee4
@ateucher
Catch when mapshaper returns empty response without throwing an error
ad9a4af
@ateucher
Remove geojsonio from Suggests
e087784
@ateucher
typo
d7c38c7
@ateucher
Update bundled rmapshaper to 0.6.25
d4ae30f
@ateucher
Start to upgrade to testthat 3e
05c54e6
@ateucher
Updated tests for dissolve
9777b67
@ateucher
Simplify points test geojson
cc64071
@ateucher
Update tests for drop_null_geometries
7f788ce
@ateucher
Update explode tests, move library calls to setup
12e5a72
@ateucher
Typo
ec90319
@ateucher
Need drop = FALSE in subsetting sp@data
2bf274c
@ateucher
update tests for filter-fields
b125d50
@ateucher
Update tests for filter-islands
91ea5c3
@ateucher
Update innerlines tests, add snaps
d64bf8c
@ateucher
Update lines tests, and move lines objects to setup
5a0fd33
@ateucher
Update gitignore
147ba6d
@ateucher
Update test-points to 3e
46880a1
@ateucher
Error in ms_points with x and y when no data
99bacbb
@ateucher
Update simplify tests to 3e
084dedb
@ateucher
deal with raw returns from V8 context
7349b0d 
- It appears empty geometrycollections come back as a raw vector...
@ateucher
Update test-utils to 3e
ed6ae60
@ateucher
Add snaps
c2f2c6c
@ateucher
Remove last use of geojsonio
49d78b4
@ateucher
Import sp classes for new as. methods
1ad63ff
@ateucher ateucher added this to the 0.5 milestone Apr 6, 2023
@ateucher ateucher merged commit b6f34b8 into main Apr 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ateucher