Avoid rebuilding cache when the primary model has been destroyed #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restrict the queueing of
RefillJob
to only happen oncreate
andupdate
events, avoid queueing the job on destroy.Thermos uses globalid serialization for the
ActiveJob
params when available, to serialize theself
instance variable to the queue backend, which is then automatically deserialized by Rails / ActiveJob, reference.For any records that were destroyed, the serialization will happen without an issue with the in-memory instance of the model, but during deserialization by the background job worker, the record will not be available causing the
RefillJob
to fail.Potential Improvement: