Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow jobs to be executed on a non-default queue #43

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Conversation

athal7
Copy link
Owner

@athal7 athal7 commented Mar 2, 2022

No description provided.

@athal7 athal7 requested a review from praveenram March 2, 2022 16:50
@athal7 athal7 force-pushed the specify-queue-name branch 2 times, most recently from 1f2b980 to 9caec9f Compare March 2, 2022 16:57
@athal7
Copy link
Owner Author

athal7 commented Mar 2, 2022

@leo3po

lib/thermos/beverage.rb Outdated Show resolved Hide resolved
Copy link
Collaborator

@praveenram praveenram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this! 🙇

lib/thermos.rb Show resolved Hide resolved
test/test_helper.rb Outdated Show resolved Hide resolved
lib/thermos/beverage.rb Outdated Show resolved Hide resolved
Copy link

@leo3po leo3po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @athal7 looks good. Small thing, noticed a few missing eof new lines.

@athal7 athal7 requested a review from praveenram March 3, 2022 14:05
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
@athal7 athal7 merged commit 11e09a2 into main Mar 4, 2022
@athal7 athal7 deleted the specify-queue-name branch March 4, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants