feat: check if function component is still mounted before updating th…

…e state
atheck · Aug 26, 2022 · 810e93b · 810e93b
1 parent a84942b
commit 810e93b
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/useElmish.ts b/src/useElmish.ts
@@ -61,9 +61,14 @@ function useElmish<TProps, TModel, TMessage extends MessageBase> ({ name, props,
     let currentModel: Partial<TModel> = {};
 
     const [model, setModel] = useState<Nullable<TModel>>(null);
-    let initializedModel = model;
-
     const propsRef = useRef(props);
+    const isMountedRef = useRef(true);
+
+    useEffect(() => () => {
+        isMountedRef.current = false;
+    }, []);
+
+    let initializedModel = model;
 
     if (propsRef.current !== props) {
         propsRef.current = props;
@@ -106,7 +111,7 @@ function useElmish<TProps, TModel, TMessage extends MessageBase> ({ name, props,
             }
             reentered = false;
 
-            if (modified) {
+            if (isMountedRef.current && modified) {
                 setModel(prevModel => {
                     const updatedModel = { ...prevModel as TModel, ...currentModel };