My fix related to issue #43 (fixed bug) #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…excerption. Changed it to a finally block instead, and check for negative index. - Because NoRM does not do enough type-checking when using update commands on MongoDB, the data stored in the database can become incompatible with the .NET class being deserialied to. This is primarily the case with arrays. An array such as List<string> may be saved in the database, then a value such as an array rather than a string can be inserted on an update. This will make the nested array stored in the database not deserialize to a list of strings. I updated the array deserialization routine to compensate for nested arrays, which lets the deserializer throw an exception when adding an element of type Array to a list of type List<string>.
… null and that there are more than 0 bytes left.
…(Type) to serialize the type information if MongoConfigurationMap.UseAsDiscriminator() was used instead of the MongoDiscriminatedAttribute.
|
thanks, will review and merge. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opted to let the deserializer continue deserializing the data structure retrieved from the database even if it was not correct according to the .NET class structure. The deserializer then throws an error when there is a Type mismatch.