Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SaslServ "LOGIN (session timed out)" log messages are useless #701

Closed
lstarnes1024 opened this issue Jun 3, 2020 · 0 comments
Closed

SaslServ "LOGIN (session timed out)" log messages are useless #701

lstarnes1024 opened this issue Jun 3, 2020 · 0 comments

Comments

@lstarnes1024
Copy link
Contributor

One of my networks has a few users who are on unstable connections, so their client keeps reconnecting and timing out during SASL authentication. This is causing our services log channel to be full of LOGIN (session timed out) messages from SaslServ, and there are about 20 of those messages for every successful LOGIN message. Additionally, the timeout happens during connection registration, so my ircd (charybdis) doesn't even log what IP they're using so I can impose a D-Line, but I don't think it's fair to do that. As a network admin, I don't have the ability to fix these clients. The log message also does not provide any value because it's not a successful authentication or even a completed but failed attempt, which could be a sign of a user's account being attacked.

Suggested fix: remove the below part of sasl_session_destroy or provide a configuration option to disable this message without disabling the other SaslServ messages:

if (mu && ! (ircd->flags & IRCD_SASL_USE_PUID))
    (void) logcommand(p->si, CMDLOG_LOGIN, "LOGIN (session timed out)");
lstarnes1024 added a commit to lstarnes1024/atheme that referenced this issue Jun 3, 2020
aaronmdjones pushed a commit that referenced this issue Jun 12, 2020
Original commit by @lstarnes1024, edited by @aaronmdjones to further
remove the flag that it depended on, now that it has no use. Shuffling
the other flag up after it is okay because the only user of this flag
is saslserv/main, and reloading that will reload all other saslserv
modules anyway, so there is no ABI concern.

cf. #701
cf. 2a446dd628ae9bf133b8

Closes #701
Closes #702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant