connect.js: clarify the connect window with an abbr element about what logging into services means #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t logging into services means
kaniini
added a commit
that referenced
this pull request
Nov 2, 2015
connect.js: clarify the connect window with an abbr element about what logging into services means
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by a comment on a forum about the accessibility of IRC, it was apparent that the welcome window's "Login to Services" option could be unclear to users with little experience with IRC, and generally webchat should try to be as straightforward as possible for anyone attempting to connect, without confusing options.
This pull request adds a small
<abbr>element to this label -Login to Services- which, when moused-over, gives further information about what this option actually does.To achieve this, the
createRowfunction was modified to allow either anElementorstringto be passed as a label, instead of just astring. This doesn't affect any previous uses of the function but allows us to pass labels such as this<abbr>one.