-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(undo/redo): textarea undo/redo; italics, highlight, underline, strikethrough #717 #803
fix(undo/redo): textarea undo/redo; italics, highlight, underline, strikethrough #717 #803
Conversation
Woweee |
@arkRedM oh you're that's a separate issue, however, undo/redo should be implemented as a tx log. The current approach holds onto the entire last 10 db values, and drops and resets on undo/redo. This is extremely slow for big dbs - takes ~2 seconds for mine at the point. I also think it's the basis for RTC, in terms of using a tx log. |
That's the reason I started with this issue as well 😆, quickly discovered that's unrelated to current bug. But I was already knee-deep, the only way out is to leave the patch in an ideal state -- hence added a few qol features while also fixing the root issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC #649 @dauberd @avidrucker
@@ -99,7 +99,7 @@ | |||
KeyCodes.BACKSLASH (if shift | |||
(dispatch [:right-sidebar/toggle]) | |||
(dispatch [:left-sidebar/toggle])) | |||
KeyCodes.H (util/toggle-10x) | |||
KeyCodes.T (util/toggle-10x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea to use ctrl-T instead of ctrl-H. H always led to weird behavior.
No description provided.