Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(undo/redo): textarea undo/redo; italics, highlight, underline, strikethrough #717 #803

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

arkRedM
Copy link
Contributor

@arkRedM arkRedM commented Mar 11, 2021

No description provided.

@tangjeff0
Copy link
Collaborator

Woweee

@arkRedM
Copy link
Contributor Author

arkRedM commented Mar 11, 2021

Screen Shot 2021-03-12 at 2 37 37 AM

Basic formatting and cmd z behavior are addressed in this patch.
This is not related to undo/redo a txn at all. What user was experiencing was not at all an issue with txn undo.
Maybe move the bounty to another issue?

@tangjeff0
Copy link
Collaborator

@arkRedM oh you're that's a separate issue, however, undo/redo should be implemented as a tx log. The current approach holds onto the entire last 10 db values, and drops and resets on undo/redo. This is extremely slow for big dbs - takes ~2 seconds for mine at the point.

I also think it's the basis for RTC, in terms of using a tx log.

@arkRedM
Copy link
Contributor Author

arkRedM commented Mar 11, 2021

I also think it's the basis for RTC, in terms of using a tx log.

That's the reason I started with this issue as well 😆, quickly discovered that's unrelated to current bug. But I was already knee-deep, the only way out is to leave the patch in an ideal state -- hence added a few qol features while also fixing the root issue

Copy link
Collaborator

@tangjeff0 tangjeff0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC #649 @dauberd @avidrucker

@@ -99,7 +99,7 @@
KeyCodes.BACKSLASH (if shift
(dispatch [:right-sidebar/toggle])
(dispatch [:left-sidebar/toggle]))
KeyCodes.H (util/toggle-10x)
KeyCodes.T (util/toggle-10x)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to use ctrl-T instead of ctrl-H. H always led to weird behavior.

@tangjeff0 tangjeff0 changed the title fix(undo/redo): undo/redo while text editing. support for basic str formats #717 fix(undo/redo): textarea undo/redo; italics, highlight, underline, strikethrough #717 Mar 11, 2021
@tangjeff0 tangjeff0 merged commit 2509b9a into athensresearch:master Mar 11, 2021
korlaism pushed a commit to korlaism/athens that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants