dataset migration #57
Conversation
WalkthroughThe updates across various files introduce a new Changes
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (10)
athina/datasets/dataset.py (2)
Line range hint
43-58: Improve exception handling by logging the exception message.- except Exception as e: - raise + except Exception as e: + print(f"Failed to create dataset: {e}") + raise
Line range hint
66-78: Improve exception handling by logging the exception message.- except Exception as e: - raise + except Exception as e: + print(f"Failed to add rows: {e}") + raiseathina/services/athina_api_service.py (8)
Line range hint
41-85: Remove the unused variableein the exception handling.- except Exception as e: - print("Exception fetching inferences", e) + except Exception: + print("Exception fetching inferences")
Line range hint
87-101: Remove the unused variableein the exception handling.- except Exception as e: - pass + except Exception: + pass
Line range hint
103-150: Remove the unused variableein the exception handling.- except Exception as e: - print( - f"An error occurred while posting eval results", - str(e), - ) + except Exception: + print( + "An error occurred while posting eval results" + )
Line range hint
132-147: Remove the unused variableein the exception handling.- except Exception as e: - raise + except Exception: + raise
Line range hint
169-184: Remove the unused variableein the exception handling.- except Exception as e: - raise + except Exception: + raise
Line range hint
186-217: Remove the unused variableein the exception handling.- except Exception as e: - print( - f"An error occurred while creating eval request", - str(e), - ) + except Exception: + print( + "An error occurred while creating eval request" + )
Line range hint
219-261: Remove the unused variableein the exception handling.- except Exception as e: - print( - f"An error occurred while posting experiment metadata", - str(e), - ) + except Exception: + print( + "An error occurred while posting experiment metadata" + )
Line range hint
263-330: Remove the unused variableein the exception handling.- except Exception as e: - raise + except Exception: + raise
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- athina/datasets/dataset.py (3 hunks)
- athina/services/athina_api_service.py (2 hunks)
- examples/dataset_creation.ipynb (3 hunks)
Additional Context Used
Ruff (15)
athina/datasets/dataset.py (5)
1-1:
jsonimported but unused
3-3:
requestsimported but unused
4-4:
dataclasses.asdictimported but unused
56-56: Local variable
eis assigned to but never used
78-78: Local variable
eis assigned to but never usedathina/services/athina_api_service.py (10)
3-3:
dataclasses.asdictimported but unused
6-6:
athina.errors.exceptions.NoAthinaApiKeyExceptionimported but unused
85-85: Local variable
eis assigned to but never used
119-119: f-string without any placeholders
150-150: Local variable
eis assigned to but never used
186-186: Local variable
eis assigned to but never used
217-217: f-string without any placeholders
261-261: f-string without any placeholders
304-304: f-string without any placeholders
330-330: Local variable
eis assigned to but never used
Additional comments not posted (7)
examples/dataset_creation.ipynb (4)
5-16: No issues found in this cell.
Line range hint
31-52: No issues found in this cell.
53-60: No issues found in this cell.
Line range hint
61-78: No issues found in this cell.athina/datasets/dataset.py (2)
Line range hint
1-12: No issues found in theDatasetRowclass.
Line range hint
79-81: No issues found in thedataset_linkmethod.athina/services/athina_api_service.py (1)
Line range hint
17-20: No issues found in the_headersmethod.
Summary by CodeRabbit
New Features
data_sourceattribute to datasets, enhancing dataset metadata.Improvements
/api/v1/dataset_v2for better versioning.Documentation
dataset.id.