Include Zsh completion file in the gem #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athityakumar
approved these changes
Nov 17, 2017
|
@avdv - Resolve the merge conflicts, please. 😄 |
.gitignore
Outdated
| docs/ | ||
| zsh/_colorls |
There was a problem hiding this comment.
I guess this _colorls auto-completion file will have to be removed from gitignore.
There was a problem hiding this comment.
Yes, of course!
I have removed it from the ignore file and added it to the commit instead.
And also adjusted the rakefile and gemspec accordingly.
Add the `_colorls` completion file to the `zsh/` folder of the gem and make the `tab_complete.sh` script work for Zsh too.
This was referenced Nov 22, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
_colorlscompletion file to thezsh/folder of the gem and make thetab_complete.shscript work for Zsh too.Description
This PR makes the tab completion work for Zsh users too. The tab_complete.sh script conditionally initializes the completion for Bash or Zsh.