Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support -A | --almost-all flag and Fix -a | --all flag #75

Merged

Conversation

adimasuhid
Copy link
Contributor

@adimasuhid adimasuhid commented Jul 11, 2017

Changes

  • Added support for -A flag
  • Fixed -a flag

Closes #57 and #39

@adimasuhid adimasuhid force-pushed the features/support_almost_all_flags branch from 113dac0 to 9cd81da Compare July 11, 2017 09:38
@athityakumar
Copy link
Owner

@adimasuhid - Thanks for working on this. 😄

How about adding tests for flags later? For now, just add the colorls -A to the travis.yml file and remove the spec (and fixtures) for the -A flag.

@adimasuhid
Copy link
Contributor Author

@athityakumar Sure will do. Though do you mean add specs in a separate PR or just remove specs all together?

@athityakumar
Copy link
Owner

@adimasuhid - I'd like it for specs to be added, provided specs for all flags are added. Else, it becomes too inconsistent. Hence,

  • For this PR, revert the spec part. Add the Travis config.
  • If you don't mind adding spec for all flag options usage (as currently done in travis.yml), please do it in a different PR. Else, no issues. We can make do with Travis build log reports as of now for reviewing PRs.

@adimasuhid
Copy link
Contributor Author

@athityakumar That makes sense thanks. Will do. I'll try to add specs for all if I have time though that's probably just the happy path for the mean time.

@adimasuhid adimasuhid force-pushed the features/support_almost_all_flags branch from 9cd81da to f3a7b93 Compare July 11, 2017 10:05
Changes:

* Add -A | --almost-all flag

* Update functionality for -a | --all
@adimasuhid adimasuhid force-pushed the features/support_almost_all_flags branch from f3a7b93 to eb4fe16 Compare July 11, 2017 10:06
@adimasuhid
Copy link
Contributor Author

@athityakumar Updated as suggested.

Out of context question though: How can you reply so fast, any time of the day? haha

@athityakumar athityakumar merged commit d62da43 into athityakumar:master Jul 11, 2017
@adimasuhid adimasuhid deleted the features/support_almost_all_flags branch July 11, 2017 10:47
@athityakumar
Copy link
Owner

@adimasuhid - Haha. Purely a matter of coincidence that I'm awake at that time. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants