This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
[Issue-55]: Gradlew test fails #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 14, 2017 12:44
Rewrote the robolectric tests to make sure mocks are properly injected and no network calls are performed. Using dagger mock library for that While I was at it I also: -Upped the gradle version -Added Butterknife view actions -Added constraint layout
Added a small description of what to look for before submitting a PR.
Fixed test crashing in CI cause of an extra space at the end of the date string
Closed
|
|
||
| @Provides | ||
| public static MainActivityViewState providesMainActivityViewState() { |
There was a problem hiding this comment.
I just removed them from that whole module, as now it needs to be instantiated by DaggerMock with a constructor call in MainPresenterTest.
a) I didn't check if DaggerMock works with static providers
b) I removed them for the whole module even though we only mock the presenter object for the sake of simplicity
There was a problem hiding this comment.
DaggerMock work fine with static
There was a problem hiding this comment.
I just tried this, it daggerMock doesn't work with static.
There was a problem hiding this comment.
@athkalia Sorry, I had left only this method as non-static
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote the robolectric tests to make sure mocks are properly injected and no network calls are performed. Using dagger mock library for that
While I was at it I also:
-Upped the gradle version
-Added Butterknife view actions
-Added constraint layout