Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Not all comments seem to always load #15

Closed
Athlon007 opened this issue Jul 17, 2023 · 4 comments
Closed

[BUG] Not all comments seem to always load #15

Athlon007 opened this issue Jul 17, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@Athlon007
Copy link
Owner

Describe the bug
It seems like some comments never get loaded when opening a post.

Expected behavior
All comments should be visible.

@Athlon007 Athlon007 added the bug Something isn't working label Jul 17, 2023
@Athlon007 Athlon007 assigned Athlon007 and unassigned Athlon007 Jul 17, 2023
@boscojwho
Copy link
Contributor

API requests might be missing a type_ parameter:

@boscojwho
Copy link
Contributor

boscojwho commented Aug 1, 2023

Relevant API doc: https://join-lemmy.org/api/types/ListingType.html

  • Not sure which parameter is most appropriate: "All"|"Local"|"Subscribed"
  • For this particular example (above comment), "Local" also returned 0 comments, only "All"/"Subscribed" returned the same set of comments.

@boscojwho
Copy link
Contributor

boscojwho commented Aug 1, 2023

After specifying "type_=All", CommentService now gets all comments, but it currently filters out comments, so child comments don't get rendered after being downloaded.

@Athlon007
Copy link
Owner Author

Should be fixed in #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants