Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where comments in PostPopup view may not load completely or at all #82

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Fix issue where comments in PostPopup view may not load completely or at all #82

merged 5 commits into from
Aug 1, 2023

Conversation

boscojwho
Copy link
Contributor

  • Specify "type_=All" when requesting comments.
  • @Athlon007 Need to look at CommentService lines 40-42, those lines are doing some filtering that's causing child comments to not show up in PostPopup view.

@boscojwho
Copy link
Contributor Author

Also, did /dev branch disappear? I meant to merge this into dev, not master.

@Athlon007 Athlon007 changed the base branch from master to dev August 1, 2023 21:18
@Athlon007
Copy link
Owner

Also, did /dev branch disappear? I meant to merge this into dev, not master.

Oops, sorry! My fault.

@Athlon007 Athlon007 merged commit e861154 into Athlon007:dev Aug 1, 2023
@Athlon007 Athlon007 mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boscojwho @Athlon007