Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updated dockerfile, deps, guide & fix src #101

Merged
merged 1 commit into from
Sep 21, 2022
Merged

feat: updated dockerfile, deps, guide & fix src #101

merged 1 commit into from
Sep 21, 2022

Conversation

yozachar
Copy link
Collaborator

@yozachar yozachar commented Sep 20, 2022 •
edited

  • fix logical error check, better non 200 resp message in main.py
  • updated dependencies
  • major updates to contributing guide
  • quicker production builds with reduced docker layers
  • adds dockerfile for development
  • updates GitHub action for unit-tests

@yozachar
Copy link
Collaborator Author

Wait for run @ 23:45 & 00:15 IST before merge.

@yozachar yozachar added documentation Improvements or additions to documentation enhancement New feature or request maintenance Maintenance Work dependencies Pull requests that update a dependency file labels Sep 20, 2022
@yozachar yozachar linked an issue Sep 20, 2022 that may be closed by this pull request
ERROR Unable to fetch data, please rerun workflow #100
Closed
@yozachar yozachar self-assigned this Sep 20, 2022
@yozachar yozachar removed a link to an issue Sep 21, 2022
ERROR Unable to fetch data, please rerun workflow #100
Closed
@yozachar
feat: updated dockerfile, deps, guide & fix src
44f2fac 
- fix logical error, better non 200 resp message in main.py
- updated dependencies
- major updates to contributing guide
- quicker prod builds with reduced docker layers
- adds dockerfile for development
- updates github action for unit-tests
@yozachar
Copy link
Collaborator Author

Last successful run 
/usr/bin/docker build -t 817f70:2d856b22e3b143b7906af160e01d73cf -f "/home/runner/work/_actions/joe733/waka-readme/workshop/dockerfile" "/home/runner/work/_actions/joe733/waka-readme/workshop"
  Sending build context to Docker daemon  388.6kB
  
  Step 1/5 : FROM python:slim-bullseye
  slim-bullseye: Pulling from library/python
  31b3f1ad4ce1: Pulling fs layer
  f335cc1597f2: Pulling fs layer
  501b4d0d8bea: Pulling fs layer
  abd735557fdf: Pulling fs layer
  9358bdbbffdc: Pulling fs layer
  abd735557fdf: Waiting
  9358bdbbffdc: Waiting
  f335cc1597f2: Verifying Checksum
  f335cc1597f2: Download complete
  501b4d0d8bea: Verifying Checksum
  501b4d0d8bea: Download complete
  31b3f1ad4ce1: Verifying Checksum
  31b3f1ad4ce1: Download complete
  abd735557fdf: Verifying Checksum
  abd735557fdf: Download complete
  9358bdbbffdc: Verifying Checksum
  9358bdbbffdc: Download complete
  31b3f1ad4ce1: Pull complete
  f335cc1597f2: Pull complete
  501b4d0d8bea: Pull complete
  abd735557fdf: Pull complete
  9358bdbbffdc: Pull complete
  Digest: sha256:6de22c9cf887098265b7614582b00641c0c8c6735af538d0f267d6bb457634f1
  Status: Downloaded newer image for python:slim-bullseye
   ---> d7971c18b18e
  Step 2/5 : ENV PYTHONFAULTHANDLER=1     PYTHONUNBUFFERED=1     PYTHONHASHSEED=random     PYTHONDONTWRITEBYTECODE=1     PIP_NO_CACHE_DIR=off     PIP_DISABLE_PIP_VERSION_CHECK=on     PIP_DEFAULT_TIMEOUT=100     POETRY_NO_INTERACTION=1     POETRY_CACHE_DIR=/var/cache/pypoetry     PATH=${PATH}:/root/.local/bin
   ---> Running in 4bc3eb9e523e
  Removing intermediate container 4bc3eb9e523e
   ---> 745b8069c82d
  Step 3/5 : COPY pyproject.toml poetry.lock main.py /
   ---> bdace16a5ef5
  Step 4/5 : RUN apt-get update && apt-get install --no-install-recommends -y curl     && curl -sSL https://install.python-poetry.org/ | python -     && poetry install --no-root --no-ansi --only main
   ---> Running in 1c1a6ef1d3f2
  Get:1 http://deb.debian.org/debian bullseye InRelease [116 kB]
  Get:2 http://deb.debian.org/debian-security bullseye-security InRelease [48.4 kB]
  Get:3 http://deb.debian.org/debian bullseye-updates InRelease [44.1 kB]
  Get:4 http://deb.debian.org/debian bullseye/main amd64 Packages [8184 kB]
  Get:5 http://deb.debian.org/debian-security bullseye-security/main amd64 Packages [184 kB]
  Get:6 http://deb.debian.org/debian bullseye-updates/main amd64 Packages [2596 B]
  Fetched 8578 kB in 1s (5732 kB/s)
  Reading package lists...
  Reading package lists...
  Building dependency tree...
  Reading state information...
  The following additional packages will be installed:
    libbrotli1 libcurl4 libldap-2.4-2 libnghttp2-14 libpsl5 librtmp1 libsasl2-2
    libsasl2-modules-db libssh2-1
  Recommended packages:
    libldap-common publicsuffix libsasl2-modules
  The following NEW packages will be installed:
    curl libbrotli1 libcurl4 libldap-2.4-2 libnghttp2-14 libpsl5 librtmp1
    libsasl2-2 libsasl2-modules-db libssh2-1
  0 upgraded, 10 newly installed, 0 to remove and 0 not upgraded.
  Need to get 1652 kB of archives.
  After this operation, 3621 kB of additional disk space will be used.
  Get:1 http://deb.debian.org/debian bullseye/main amd64 libbrotli1 amd64 1.0.9-2+b2 [279 kB]
  Get:2 http://deb.debian.org/debian bullseye/main amd64 libsasl2-modules-db amd64 2.1.27+dfsg-2.1+deb11u1 [69.1 kB]
  Get:3 http://deb.debian.org/debian bullseye/main amd64 libsasl2-2 amd64 2.1.27+dfsg-2.1+deb11u1 [106 kB]
  Get:4 http://deb.debian.org/debian bullseye/main amd64 libldap-2.4-2 amd64 2.4.57+dfsg-3+deb11u1 [232 kB]
  Get:5 http://deb.debian.org/debian bullseye/main amd64 libnghttp2-14 amd64 1.43.0-1 [77.1 kB]
  Get:6 http://deb.debian.org/debian bullseye/main amd64 libpsl5 amd64 0.21.0-1.2 [57.3 kB]
  Get:7 http://deb.debian.org/debian bullseye/main amd64 librtmp1 amd64 2.4+20151223.gitfa8646d.1-2+b2 [60.8 kB]
  Get:8 http://deb.debian.org/debian bullseye/main amd64 libssh2-1 amd64 1.9.0-2 [156 kB]
  Get:9 http://deb.debian.org/debian bullseye/main amd64 libcurl4 amd64 7.74.0-1.3+deb11u3 [345 kB]
  Get:10 http://deb.debian.org/debian bullseye/main amd64 curl amd64 7.74.0-1.3+deb11u3 [269 kB]
  debconf: delaying package configuration, since apt-utils is not installed
  Fetched 1652 kB in 0s (22.7 MB/s)
  Selecting previously unselected package libbrotli1:amd64.
  (Reading database ... 
  (Reading database ... 5%
  (Reading database ... 10%
  (Reading database ... 15%
  (Reading database ... 20%
  (Reading database ... 25%
  (Reading database ... 30%
  (Reading database ... 35%
  (Reading database ... 40%
  (Reading database ... 45%
  (Reading database ... 50%
  (Reading database ... 55%
  (Reading database ... 60%
  (Reading database ... 65%
  (Reading database ... 70%
  (Reading database ... 75%
  (Reading database ... 80%
  (Reading database ... 85%
  (Reading database ... 90%
  (Reading database ... 95%
  (Reading database ... 100%
  (Reading database ... 7031 files and directories currently installed.)
  Preparing to unpack .../0-libbrotli1_1.0.9-2+b2_amd64.deb ...
  Unpacking libbrotli1:amd64 (1.0.9-2+b2) ...
  Selecting previously unselected package libsasl2-modules-db:amd64.
  Preparing to unpack .../1-libsasl2-modules-db_2.1.27+dfsg-2.1+deb11u1_amd64.deb ...
  Unpacking libsasl2-modules-db:amd64 (2.1.27+dfsg-2.1+deb11u1) ...
  Selecting previously unselected package libsasl2-2:amd64.
  Preparing to unpack .../2-libsasl2-2_2.1.27+dfsg-2.1+deb11u1_amd64.deb ...
  Unpacking libsasl2-2:amd64 (2.1.27+dfsg-2.1+deb11u1) ...
  Selecting previously unselected package libldap-2.4-2:amd64.
  Preparing to unpack .../3-libldap-2.4-2_2.4.57+dfsg-3+deb11u1_amd64.deb ...
  Unpacking libldap-2.4-2:amd64 (2.4.57+dfsg-3+deb11u1) ...
  Selecting previously unselected package libnghttp2-14:amd64.
  Preparing to unpack .../4-libnghttp2-14_1.43.0-1_amd64.deb ...
  Unpacking libnghttp2-14:amd64 (1.43.0-1) ...
  Selecting previously unselected package libpsl5:amd64.
  Preparing to unpack .../5-libpsl5_0.21.0-1.2_amd64.deb ...
  Unpacking libpsl5:amd64 (0.21.0-1.2) ...
  Selecting previously unselected package librtmp1:amd64.
  Preparing to unpack .../6-librtmp1_2.4+20151223.gitfa8646d.1-2+b2_amd64.deb ...
  Unpacking librtmp1:amd64 (2.4+20151223.gitfa8646d.1-2+b2) ...
  Selecting previously unselected package libssh2-1:amd64.
  Preparing to unpack .../7-libssh2-1_1.9.0-2_amd64.deb ...
  Unpacking libssh2-1:amd64 (1.9.0-2) ...
  Selecting previously unselected package libcurl4:amd64.
  Preparing to unpack .../8-libcurl4_7.74.0-1.3+deb11u3_amd64.deb ...
  Unpacking libcurl4:amd64 (7.74.0-1.3+deb11u3) ...
  Selecting previously unselected package curl.
  Preparing to unpack .../9-curl_7.74.0-1.3+deb11u3_amd64.deb ...
  Unpacking curl (7.74.0-1.3+deb11u3) ...
  Setting up libpsl5:amd64 (0.21.0-1.2) ...
  Setting up libbrotli1:amd64 (1.0.9-2+b2) ...
  Setting up libnghttp2-14:amd64 (1.43.0-1) ...
  Setting up libsasl2-modules-db:amd64 (2.1.27+dfsg-2.1+deb11u1) ...
  Setting up librtmp1:amd64 (2.4+20151223.gitfa8646d.1-2+b2) ...
  Setting up libsasl2-2:amd64 (2.1.27+dfsg-2.1+deb11u1) ...
  Setting up libssh2-1:amd64 (1.9.0-2) ...
  Setting up libldap-2.4-2:amd64 (2.4.57+dfsg-3+deb11u1) ...
  Setting up libcurl4:amd64 (7.74.0-1.3+deb11u3) ...
  Setting up curl (7.74.0-1.3+deb11u3) ...
  Processing triggers for libc-bin (2.31-13+deb11u4) ...
  Retrieving Poetry metadata
  
  # Welcome to Poetry!
  
  This will download and install the latest version of Poetry,
  a dependency and package manager for Python.
  
  It will add the `poetry` command to Poetry's bin directory, located at:
  
  /root/.local/bin
  
  You can uninstall at any time by executing this script with the --uninstall option,
  and these changes will be reverted.
  
  Installing Poetry (1.2.1)
  Installing Poetry (1.2.1): Creating environment
  Installing Poetry (1.2.1): Installing Poetry
  Installing Poetry (1.2.1): Creating script
  Installing Poetry (1.2.1): Done
  
  Poetry (1.2.1) is installed now. Great!
  
  You can test that everything is set up by executing:
  
  `poetry --version`
  
  Creating virtualenv waka-readme-il7asoJj-py3.10 in /var/cache/pypoetry/virtualenvs
  Installing dependencies from lock file
  
  Package operations: 15 installs, 0 updates, 0 removals
  
    • Installing pycparser (2.21)
    • Installing certifi (2022.9.14)
    • Installing cffi (1.15.1)
    • Installing charset-normalizer (2.1.1)
    • Installing idna (3.4)
    • Installing six (1.16.0)
    • Installing urllib3 (1.26.12)
    • Installing wrapt (1.14.1)
    • Installing deprecated (1.2.13)
    • Installing pyjwt (2.5.0)
    • Installing pynacl (1.5.0)
    • Installing python-dateutil (2.8.2)
    • Installing requests (2.28.1)
    • Installing faker (13.16.0)
    • Installing pygithub (1.55)
  Removing intermediate container 1c1a6ef1d3f2
   ---> 85bcb30120cf
  Step 5/5 : CMD [ "poetry", "run", "python", "/main.py" ]
   ---> Running in 9e3a42ee2da1
  Removing intermediate container 9e3a42ee2da1
   ---> 9a624b6259dd
  Successfully built 9a624b6259dd
  Successfully tagged 817f70:2d856b22e3b143b7906af160e01d73cf

@yozachar yozachar merged commit c207519 into athul:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yozachar yozachar

Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request maintenance Maintenance Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@yozachar