Add metrics exception logs (#84)

* add logs in MetricsTimer * add logs in HttpContextHelper --------- Co-authored-by: Станислав Терещенков <tereschenkov.s@ati.su>
atidev · Jun 19, 2024 · 0904bc9 · 0904bc9
1 parent 18b0439
commit 0904bc9
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 20 deletions.
diff --git a/ATI.Services.Common/Http/HttpContextHelper.cs b/ATI.Services.Common/Http/HttpContextHelper.cs
@@ -2,14 +2,18 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using ATI.Services.Common.Logging;
 using ATI.Services.Common.Metrics;
 using Microsoft.AspNetCore.Http;
 using Microsoft.Extensions.Primitives;
+using NLog;
 
 namespace ATI.Services.Common.Http;
 
 internal static class HttpContextHelper
 {
+    private static readonly Logger Logger = LogManager.GetCurrentClassLogger();
+
     public static string[] MetricsHeadersValues(HttpContext? httpContext) => GetHeadersValues(httpContext, MetricsLabelsAndHeaders.UserHeaders);
     public static Dictionary<string, string> HeadersAndValuesToProxy(HttpContext? httpContext,IReadOnlyCollection<string>? headersToProxy) => GetHeadersAndValues(httpContext, headersToProxy);
 
@@ -24,8 +28,9 @@ private static string[] GetHeadersValues(HttpContext? httpContext, IReadOnlyColl
             var headersValues = headersNames.Select(label => GetHeaderValue(httpContext, label)).ToArray();
             return headersValues;
         }
-        catch (ObjectDisposedException) // when thing happen outside http ctx e.g eventbus event handler
+        catch (ObjectDisposedException ex) // when thing happen outside http ctx e.g eventbus event handler
         {
+            Logger.ErrorWithObject(ex, headersNames);
             return Array.Empty<string>();
         }
     }

diff --git a/ATI.Services.Common/Metrics/MetricsTimer.cs b/ATI.Services.Common/Metrics/MetricsTimer.cs
@@ -57,31 +57,38 @@ public void Stop()
 
     public void Dispose()
     {
-        if (_summary == null)
+        try
         {
-            return;
-        }
+            if (_summary == null)
+            {
+                return;
+            }
 
-        if (_summaryLabels == null)
-        {
-            _summary.Observe(_stopwatch.ElapsedMilliseconds);
-        }
-        else
-        {
-            _summary.Labels(_summaryLabels).Observe(_stopwatch.ElapsedMilliseconds);
-        }
+            if (_summaryLabels == null)
+            {
+                _summary.Observe(_stopwatch.ElapsedMilliseconds);
+            }
+            else
+            {
+                _summary.Labels(_summaryLabels).Observe(_stopwatch.ElapsedMilliseconds);
+            }
 
-        _stopwatch.Stop();
+            _stopwatch.Stop();
+
+            if (_longRequestTime == null
+                || !(_stopwatch.Elapsed > _longRequestTime)
+                || _context == null
+                || _logSource == null)
+            {
+                return;
+            }
 
-        if (_longRequestTime == null
-            || !(_stopwatch.Elapsed > _longRequestTime)
-            || _context == null
-            || _logSource == null)
+            Logger.LogWithObject(LogLevel.Warn, null, "Long request WARN.", GetContext());
+        }
+        catch (Exception ex)
         {
-            return;
+            Logger.ErrorWithObject(ex, new { _summary?.LabelNames, _summaryLabels, _logSource, MetricsLabelsAndHeaders.UserHeaders });
         }
-
-        Logger.LogWithObject(LogLevel.Warn, null, "Long request WARN.", GetContext());
     }
 
     private Dictionary<object, object> GetContext()