Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed pdb's instead of having them separate in package. #78

Closed
AraHaan opened this issue Feb 14, 2021 · 1 comment · Fixed by #79
Closed

Embed pdb's instead of having them separate in package. #78

AraHaan opened this issue Feb 14, 2021 · 1 comment · Fixed by #79

Comments

@AraHaan
Copy link
Contributor

AraHaan commented Feb 14, 2021

I would like the pdb's on here to be embedded instead due to the fact that .NET Core does support embedded pdbs it seems.

Also it would help users with debugging as well as then the pdbs are included inside of the dll's and not separate (and also would not be missing), plus with sourcelink would make it 👌.

Also embedding pdb's unconditionally also is a benefit because then this can be nuked from your csproj as well:

<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
@atifaziz
Copy link
Owner

Closed via 8ed3e27 that was merge of PR #79.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants