Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LOCALAPPDATA and cygwin support. #15

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

klknn
Copy link
Contributor

@klknn klknn commented Feb 27, 2021

Hello. This PR will fix two windows issues.

  1. In Windows, dub prefers %LOCALAPPDATA% to %APPDATA%. https://github.com/dlang/dub/blob/cfd23b4a2c33967c44b7ac154fde5b813098f648/source/dub/dub.d#L268-L270
  2. expand-file-name on dub-pkg-dir and dub describe output (using backslash \\) does not work for cygwin/msys2. I used cygwin-convert-file-name-from-windows to translate the win path to posix syntax. https://www.gnu.org/software/emacs/manual/html_node/elisp/File-Names.html#DOCF15

@atilaneves
Copy link
Owner

I... somehow missed this at the time, sorry.

@atilaneves atilaneves merged commit 0799b16 into atilaneves:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants