Fix linking on Debian/Ubuntu #36
Conversation
Which don't have the expected unversioned libclang.so symlink in the default lib dirs. I've added the dirs up to LLVM v20 (current version is 15) for some future-proofness.
kinke
force-pushed
the
link_on_debian_ubuntu
branch
from
d0aced3
to
66e4c8c
Compare
kinke
force-pushed
the
link_on_debian_ubuntu
branch
from
66e4c8c
to
96d3352
Compare
| @@ -40,14 +41,18 @@ jobs: | |||
| with: | |||
| compiler: ${{ matrix.dc }} | |||
|
|
|||
| - name: Setup C++ | |||
| - name: 'Non-Linux: Setup C++' | |||
There was a problem hiding this comment.
I don't understand why this change is needed, given that it was working fine before. Is there something special about Ubuntu 22.04?
There was a problem hiding this comment.
If you can explain the problem, I can fix it in setup-cpp.
setup-cpp already sets many of the needed variables; you should not need manual handling of it. Also, nothing has changed on Ubuntu 22.
https://github.com/aminya/setup-cpp/blob/43c67b8a9c5b5a98b07816e3ccfdb4758dba5f7d/src/llvm/llvm.ts#L72
There was a problem hiding this comment.
The point is to test whether it's working out of the box on at least 2 different Ubuntu versions, by installing the libclang-dev apt package, instead of doing some special GitHub-Actions setup that noone in real life uses on his dev box. (And had to work around by creating libclang.so symlinks manually, as we did at Symmetry.)
Which don't have the expected unversioned
libclang.sosymlink in the default lib dirs. I've added the dirs up to LLVM v20 (current version is 15) for some future-proofness.Tested manually on Ubuntu 22, works (v14).