fix(icon): click icon (svg) to change source position of tooltip, but tooltip is not closed when tooltip is bound to the component or native tag containing thy-icon INFR-8660 #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, but the tooltip is not closed when tooltip is bound to the component or native tag containing thy-icon. INFR-8660
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
minlovehua
changed the title
…lovehua/icon-tooltip-8660
walkerkay
reviewed
Jul 18, 2023
src/icon/icon.component.ts
Outdated
| @@ -133,6 +133,13 @@ export class ThyIconComponent implements OnInit, OnChanges { | |||
| } | |||
| } | |||
|
|
|||
| private setSvgPointerEvents() { | |||
There was a problem hiding this comment.
我理解这个逻辑完全可以用 css 实现吧，是不是没必要通过 js 实现
… tooltip is not closed when tooltip is bound to the component or native tag containing thy-icon INFR-8660
walkerkay
approved these changes
Jul 24, 2023
…lovehua/icon-tooltip-8660
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tooltip 绑定在子元素含有 svg 的组件或原生标签，hover 出来 tooltip 后，点击 svg 元素，编程（比如对列表排序）使得 tooltip 源位置发生变化，tooltip 没有关闭【点击 svg，当其绑定 tooltip 的父元素位置发生变化后，无法触发父元素的 mouseleave 事件】
可复现场景：