Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(layout): support thyDragMinWidth for sidebar #INFR-3948 #2814

Closed
wants to merge 2 commits into from

Conversation

minlovehua
Copy link
Contributor

@minlovehua minlovehua commented Aug 29, 2023

thy-sidebar 已经支持了拖拽时限制最小宽度的功能 thyCollapsedWidth。不考虑新增 thyDragMinWidth 参数,因为,在支持用户设置 thyCollapsible 为true 的同时,也支持用户设置 thyDraggable 为true,此时,thyCollapsedWidth 和 thyDragMinWidth 都是限制最小宽度,参数意义重复。
image

@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tethys ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 1:14pm

@Guoxiin
Copy link
Contributor

Guoxiin commented Aug 30, 2023

thy-sidebar 已经支持了拖拽时限制最小宽度的功能 thyCollapsedWidth。不考虑新增 thyDragMinWidth 参数,因为,在支持用户设置 thyCollapsible 为true 的同时,也支持用户设置 thyDraggable 为true,此时,thyCollapsedWidth 和 thyDragMinWidth 都是限制最小宽度,参数意义重复。 image

拖拽最小宽度和折叠后宽度不是一个东西吧,折叠前后内容不一样,我想设置个拖拽后(折叠前)不压字的最小宽度,就一定要改变折叠后的宽度吗?我是这么想的,你可以再找大家确认下需不需要做

@minlovehua minlovehua marked this pull request as draft August 30, 2023 02:39
@minlovehua minlovehua closed this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants