Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid): add thyFlex and thyFlexItem #INFR-9429 #2821

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

why520crazy
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tethys ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 9:04am

Copy link
Contributor Author

@why520crazy why520crazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 重构了文档,去掉一些无用的说明,直接展示示例,把 legacy grid 改为 flex grid, thyRow 和 thyCol 有些场景下还是可以使用的
  2. 新增 thyFlex 和 thyFlexItem 组件/指令,更好的使用 Flex 布局,无需记住之前的样式
  3. thyCol 支持直接通过 thyCol="2" 设置 span,简化使用,重构代码,使用 takeUntilDestroyed 取消订阅
  4. 补充了一些 Flex Grid (thyRow 和 thyCol)的测试

src/grid/flex.ts Outdated
// /**
// * Flex 方向,如果 thyDirection 传递了值,以 thyDirection 为主
// */
// @Input() thyFlex: ThyFlexDirection;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要要的注释 删除一下?

<thy-divider thyText="Custom Grow"></thy-divider>
<div thyFlex thyDirection="row" thyGap="8">
<div thyFlexItem thyGrow="1"><div class="light-blue">Item 1</div></div>
<div thyFlexItem thyShift="1"><div class="blue">Item 2</div></div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thyShift 是不是写错了? thyShrink

@why520crazy why520crazy merged commit 534f1a3 into master Aug 30, 2023
7 checks passed
@why520crazy why520crazy deleted the why520crazy/#INFR-9429 branch August 30, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants