-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grid): add thyFlex and thyFlexItem #INFR-9429 #2821
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 重构了文档,去掉一些无用的说明,直接展示示例,把 legacy grid 改为 flex grid, thyRow 和 thyCol 有些场景下还是可以使用的
- 新增 thyFlex 和 thyFlexItem 组件/指令,更好的使用 Flex 布局,无需记住之前的样式
- thyCol 支持直接通过
thyCol="2"
设置 span,简化使用,重构代码,使用 takeUntilDestroyed 取消订阅 - 补充了一些 Flex Grid (thyRow 和 thyCol)的测试
src/grid/flex.ts
Outdated
// /** | ||
// * Flex 方向,如果 thyDirection 传递了值,以 thyDirection 为主 | ||
// */ | ||
// @Input() thyFlex: ThyFlexDirection; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不需要要的注释 删除一下?
<thy-divider thyText="Custom Grow"></thy-divider> | ||
<div thyFlex thyDirection="row" thyGap="8"> | ||
<div thyFlexItem thyGrow="1"><div class="light-blue">Item 1</div></div> | ||
<div thyFlexItem thyShift="1"><div class="blue">Item 2</div></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thyShift 是不是写错了? thyShrink
No description provided.