Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdown): When clicking Disabled Menu Item, the drop-down box does not need to be closed #INFR-8028 #2983

Closed
wants to merge 5 commits into from

Conversation

yanglusen
Copy link

No description provided.

Copy link

vercel bot commented Dec 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tethys ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 9:43am

cdk/dom/abstract-element-renderer.ts Show resolved Hide resolved
src/dropdown/styles/dropdown.scss Outdated Show resolved Hide resolved
src/dropdown/dropdown-menu-item.directive.ts Outdated Show resolved Hide resolved
src/dropdown/styles/dropdown.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@Guoxiin Guoxiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 目前方案禁用不掉 a 标签的点击事件,还需要再考虑下
  2. 后续如果有其他方案实现了,也需要补充下单元测试

@@ -139,7 +139,6 @@

&--disabled {
opacity: 0.5;
pointer-events: none;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pointer-events: none; 去掉的话,鼠标事件会禁用不成功,比如click事件。 我们有这种使用场景:

image

@hjm100 hjm100 closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants