refactor(select): rename native select and custom select and provide schematics #INFR-10691 #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
why520crazy
requested changes
Feb 23, 2024
| }, | ||
| { | ||
| replace: '</thy-custom-select>', | ||
| replaceWith: '</thy-select>' |
There was a problem hiding this comment.
V17 的 Schematics 迁移不能放在之前的 data 文件夹，之前那个是 V16 的 Schematics 迁移，我为了让做 V17 Schematics 的人参考没有删除， 所以需要在 V17 update 中单独定义 elementSelectors 并追加到 V17 的 update 中去 @luxiaobei 应该是这样吧
There was a problem hiding this comment.
这里既然加了 Schematics 最好写测试验证一下
| * @name thy-select | ||
| * @order 20 | ||
| * @order 10 | ||
| */ | ||
| @Component({ | ||
| selector: 'thy-select', |
There was a problem hiding this comment.
之前的 Custom Select 位置可以不用改，放在之前的 custom-select 文件夹下也可以，但是要记住选择器保持兼容，两个都支持一下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
一、原生select组件的调整
<thy-select --> <thy-native-select</thy-select> --> </thy-native-select>ThySelectComponent --> ThyNativeSelectComponent.thy-select不改。它属于 select 模块，不只是属于 thy-native-select组件。二、自定义select组件的调整
<thy-custom-select --> <thy-select</thy-custom-select> --> </thy-select>ThySelectCustomComponent --> ThySelectComponentThyCustomSelectTriggerType --> ThySelectTriggerType三、提供 schematics 迁移规则